Repository navigation
DEV-1478: Shimmer Capture's Sound_Level gets a panel of its own - #355
Merged
Merged
Conversation
In the Other panel its axis was shared with the battery's percentage, the ExG status channels and the event marker, so a few dB of change filled a few percent of the panel. It now has a Sound level panel, just before Other, as shimmer-host-core's CAPTURE.md does from ShimmerResearch/shimmer-host-core#116. Panels, CaptureRulesTest, the README and the window's Sound level tooltip. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #354, which merged before this commit reached it.
In Shimmer Capture's plot, a Shimmer3R's
Sound_Levelwas in the Other panel. There it shares one axis withBatt_Percentage(0–100 %), the ExG status channels andEvent_Marker. On the bench the level moved between 50.9 and 52.5 dB(A), so with the battery near 90 % in the same panel the change filled only a few percent of its height.It now has a Sound level panel of its own, just before Other. shimmer-host-core's
CAPTURE.mdand its eight Capture apps make the same change in ShimmerResearch/shimmer-host-core#116, so the apps keep the same panels.Jira: DEV-1478.
What changed
Panels: "Sound level" in the list before "Other", andSound_Levelgoes to it.CaptureRulesTest:Sound_Levelexpects Sound level, and the panel sits just before Other.Tests
./gradlew :test --tests 'com.shimmerresearch.capture.*'inShimmerPCBasicExamples: 26 of 26. CI does not build this module.To check by hand: with Sound level ticked and written, start streaming.
Sound_Levelshows in its own Sound level panel, and no longer in Other.Elsewhere
🤖 Generated with Claude Code